Skip to content

Development#6

Merged
ianmseddy merged 12 commits intoPredictiveEcology:developmentfrom
vanelslander-ecology:development
Jul 8, 2025
Merged

Development#6
ianmseddy merged 12 commits intoPredictiveEcology:developmentfrom
vanelslander-ecology:development

Conversation

@vanelslander-ecology
Copy link
Copy Markdown

add a title parameter for scfmDiagnostics plots

@achubaty
Copy link
Copy Markdown
Contributor

the title argument should be NULL by default to allow backwards compatibility, and the functions should be able to handle NULL

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2025

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@achubaty
Copy link
Copy Markdown
Contributor

achubaty commented May 12, 2025

instead of duplicating the figure code in separate blocks, we can do the following, which is easier to read/maintain:

gg <- ggplot() + ... ## build the plot

if (!is.null(title)) {
  gg <- gg + ggtitle(title)
}

@vanelslander-ecology
Copy link
Copy Markdown
Author

I updated the functions so they're can handle runName = NULL now

@ianmseddy ianmseddy merged commit 9119254 into PredictiveEcology:development Jul 8, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants