Skip to content

fix(metal): filter compiler errors from JIT header dependency parsing #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mirsad-presagetech wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(metal): filter compiler errors from JIT header dependency parsing #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions mlx/backend/metal/make_compiled_preamble.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,10 @@ mkdir -p "$OUTPUT_DIR"
CCC="xcrun -sdk macosx metal -x metal"
HDRS=$( $CCC -I"$SRC_DIR" -I"$JIT_INCLUDES" -DMLX_METAL_JIT -E -P -CC -C -H "$INPUT_FILE" $CFLAGS -w 2>&1 1>/dev/null )

# Remove any included system frameworks (for MetalPerformancePrimitive headers)
HDRS=$(echo "$HDRS" | grep -v "Xcode")
# Filter to only keep valid -H output lines (dots followed by absolute path)
# This removes compiler error/warning messages and other unexpected output
# Also remove system framework paths (Xcode paths for MetalPerformancePrimitives, etc.)
HDRS=$(echo "$HDRS" | grep -E "^\.+ /" | grep -v "Xcode")

# Use the header depth to sort the files in order of inclusion
declare -a HDRS_LIST=($HDRS)
Expand Down