Skip to content

ps_banner module forces the 'http://' prefix to its link#66

Open
ShaiMagal wants to merge 1 commit intoPrestaShop:devfrom
ShaiMagal:dev
Open

ps_banner module forces the 'http://' prefix to its link#66
ShaiMagal wants to merge 1 commit intoPrestaShop:devfrom
ShaiMagal:dev

Conversation

@ShaiMagal
Copy link
Copy Markdown

@ShaiMagal ShaiMagal commented Sep 8, 2025

Questions Answers
Description? We shouldn't force any protocol. We should leave url "as is".
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? PrestaShop/PrestaShop#39524
How to test? Add link without http:// and without https://, then check, if there is link as user write exactly.

@ps-jarvis
Copy link
Copy Markdown

Hello @ShaiMagal!

This is your first pull request on ps_banner repository of the PrestaShop project.

Thank you, and welcome to this Open Source community!

@ShaiMagal
Copy link
Copy Markdown
Author

ShaiMagal commented Sep 8, 2025

Tests are failing because of

"This request has been automatically failed because it uses a deprecated version of actions/cache: v1. Please update your workflow to use v3/v4 of actions/cache to avoid interruptions. Learn more: https://github.blog/changelog/2024-12-05-notice-of-upcoming-releases-and-breaking-changes-for-github-actions/#actions-cache-v1-v2-and-actions-toolkit-cache-package-closing-down"

Can someone fix this? (too unfamiliar for me)

@tleon
Copy link
Copy Markdown

tleon commented Oct 15, 2025

Hello I created this PR #68 it should fix the CI exepect the E2E tests ( the errors are code related not CI related). Once merged, you should be able to rebase your branch and it should be better.

@Touxten Touxten closed this Mar 8, 2026
@github-project-automation github-project-automation bot moved this from Ready for review to Closed in PR Dashboard Mar 8, 2026
@Touxten Touxten reopened this Mar 8, 2026
@github-project-automation github-project-automation bot moved this from Ready for review to Reopened in PR Dashboard Mar 8, 2026
@ps-jarvis ps-jarvis moved this from Closed to Ready for review in PR Dashboard Mar 8, 2026
@Touxten
Copy link
Copy Markdown
Contributor

Touxten commented Mar 9, 2026

Can yu rebase @ShaiMagal 🚀

@Touxten Touxten closed this Mar 10, 2026
@github-project-automation github-project-automation bot moved this from Reopened to Closed in PR Dashboard Mar 10, 2026
@Touxten Touxten reopened this Mar 10, 2026
@ps-jarvis ps-jarvis moved this from Closed to Reopened in PR Dashboard Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Reopened

Development

Successfully merging this pull request may close these issues.

5 participants