Module doesn't show on mobile version of Chrome.#83
Open
Touxten wants to merge 1 commit intoPrestaShop:devfrom
Open
Module doesn't show on mobile version of Chrome.#83Touxten wants to merge 1 commit intoPrestaShop:devfrom
Touxten wants to merge 1 commit intoPrestaShop:devfrom
Conversation
Contributor
Touxten
commented
Mar 10, 2026
Touxten
commented
| Questions | Answers |
|---|---|
| Description? | Module doesn't show on mobile version of Chrome. |
| Type? | bug fix |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | #9 |
| How to test? | See issue |
Contributor
Author
|
I don't think an upgrade file is necessary? |
Contributor
Contributor
Author
|
For better tracking, I prefer to make several PRs. I will propose other PRs when I have time. |
jf-viguier
approved these changes
Mar 19, 2026
|
I'm not sure that's a good idea. Full width banners suited for desktop version usually don't look good on mobile. Besides having a banner on top of every page, especially on mobile isn't useful. Unless the module provides a way to add a mobile version of the banner it's better to keep it disabled. |
Contributor
Author
Contributor
|
Disabling display a banner on mobile can be made in css with bootstrap class. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.