Last button should be updated like others

[alfonsolr09]

Questions	Answers
Description?	Modules - Buttons should be updated see PrestaShop/PrestaShop#21361
Type?	bug fix / improvement / new feature / refacto / critical
BC breaks?	no
Deprecations?	no
Fixed ticket?	Fixes PrestaShop/Prestashop#{issue number here}.
How to test?	Please indicate how to best verify that this PR is correct.

LAST BUTTON UPDATED TO YES/ NO

[florine2623]

@alfonsolr09 , Can you specify how to test and add screenshots ?

[alfonsolr09]

@alfonsolr09 , Can you specify how to test and add screenshots ?

Same PR like #18

[alfonsolr09]

@florine2623

[kpodemski]

I think "Enabled", "Disabled" works better in this scenario.

cc @Julievrz

[alfonsolr09]

I think "Enabled", "Disabled" works better in this scenario.

cc @Julievrz

I think so too, but since the other two buttons were modified, they should all be the same. It seems unsightly to me that in two of them it says "yes/no" and in another it says "enabled/disabled"

[kpodemski]

I'll let @Julievrz decide what to do there. Maybe best would be to rethink labels for fields from this module.

[alfonsolr09]

How about "on/off"? Is international and no need translation

[Julievrz]

Hi, what button are we talking about? Can you add a screenshot, please? I don't have enough context to answer. :)

[alfonsolr09]

@Julievrz

[Julievrz]

@kpodemski @alfonsolr09 In this case, the easiest thing to do might be to modify the third label to match the construction of the other two (starting with an action verb).

So we would have: "Detect plugins" Yes/No

But I'm wondering why all toggle buttons wording are modified to "Yes/No". Yes/No forces the user to read the label to understand the state of the feature. "Enabled/Disabled", "Activated/Deactivated" or even "On/Off" would be clearer.

[alfonsolr09]

Throughout the project I think the labels are being modified in that way (yes/no).
I also think it would be clearer by putting "on/off" and it is a universal language and would not need a translation.

[kpodemski]

@MatShir why blocked?

[MatShir]

Blocked by wording !

[alfonsolr09]

Blocked by wording !

What does it mean?

[MatShir]

Hi @alfonsolr09,

Blocked by wording !

What does it mean?

Indeed, here we have @Julievrz & @axelvrsc in charge of the overall coherence of the wording. They have their doubts about the choices made by the initiative. The PR is blocked, so they can think about the best content.

[Hlavtox]

@alfonsolr09 Please fill out the PR description. :-)

[alfonsolr09]

@alfonsolr09 Please fill out the PR description. :-)

done!

Dismissing for now, PR technically OK, but maybe original wording is better