Skip to content

Fix customer lastNameType #873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nesrineabdmouleh merged 1 commit into from
Mar 19, 2026
Merged

Fix customer lastNameType #873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/data/faker/customer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export default class FakerCustomer {

public readonly firstName: string;

public readonly lastName: string | null;
public readonly lastName: string;

public email: string;

Expand Down
2 changes: 1 addition & 1 deletion src/data/types/customer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ export type CustomerCreator = {
guestAccount?: boolean
socialTitle?: string
firstName?: string
lastName?: string|null
lastName?: string
birthdate?: string
yearOfBirth?: string
monthOfBirth?: string
Expand Down
2 changes: 1 addition & 1 deletion src/versions/develop/pages/BO/customers/create.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ class BOCustomersCreatePage extends BOBasePage implements BOCustomersCreatePageI

// Fill form
await this.setValue(page, this.firstNameInput, customerData.firstName);
await this.setValue(page, this.lastNameInput, customerData.lastName!);
await this.setValue(page, this.lastNameInput, customerData.lastName);
await this.setValue(page, this.emailInput, customerData.email);
await this.setValue(page, this.passwordInput, customerData.password);
await this.selectByVisibleText(page, this.yearOfBirthSelect, customerData.yearOfBirth);
Expand Down
2 changes: 1 addition & 1 deletion src/versions/develop/pages/FO/classic/checkout/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,7 +611,7 @@ class CheckoutPage extends FOBasePage implements FoCheckoutPageInterface {
await this.setChecked(page, this.checkoutGuestGenderInput(customerData.socialTitle === 'Mr.' ? 1 : 2));

await this.setValue(page, this.checkoutGuestFirstnameInput, customerData.firstName);
await this.setValue(page, this.checkoutGuestLastnameInput, customerData.lastName!);
await this.setValue(page, this.checkoutGuestLastnameInput, customerData.lastName);
await this.setValue(page, this.checkoutGuestEmailInput, customerData.email);
if (this.theme === 'hummingbird') {
await this.setChecked(page, this.createAccountCheckbox, true);
Expand Down
2 changes: 1 addition & 1 deletion src/versions/develop/pages/FO/classic/myAccount/create.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ class FoCreateAccountPage extends FOBasePage implements FoCreateAccountPageInter
async createAccount(page: Page, customer: FakerCustomer): Promise<void> {
await this.waitForSelectorAndClick(page, this.genderRadioButton(customer.socialTitle === 'Mr.' ? 1 : 2));
await this.setValue(page, this.firstNameInput, customer.firstName);
await this.setValue(page, this.lastNameInput, customer.lastName!);
await this.setValue(page, this.lastNameInput, customer.lastName);
await this.setValue(page, this.newEmailInput, customer.email);
await this.setValue(page, this.newPasswordInput, customer.password);

Expand Down
Loading