fix(tests): enhance address handling and testing coverage in CartPresenter#1426
Closed
gaelreyrol wants to merge 1 commit into5.3.xfrom
Closed
fix(tests): enhance address handling and testing coverage in CartPresenter#1426gaelreyrol wants to merge 1 commit into5.3.xfrom
gaelreyrol wants to merge 1 commit into5.3.xfrom
Conversation
gaelreyrol
force-pushed
the
fix/unit-tests
branch
from
72a6e4b to
84d1e94
Compare
…enter ### Description - Improved null checks for address initialization in `CartPresenter` to handle missing `id_address_delivery` and `id_address_invoice`. - Enhanced test coverage in `CartPresenterTest`, adding mock initialization for currency, addresses, and gift wrapping functionality. - Updated type annotations in `OrderPayloadUtility` to provide detailed parameter structure. - Added coverage annotations to unit tests for improved testing clarity. - Implemented additional breakdown fields (`insurance`, `shipping_discount`) in `AmountBreakdownNodeTest` for completeness. - Refined `BodyValuesValidatorTest` to validate new webhook parameters (`eventStream`, `eventNumber`, `webhookId`). - Commented out redundant test assertions in `UpdateExternalPayPalOrderProcessorTest` to streamline logic.
gaelreyrol
force-pushed
the
fix/unit-tests
branch
from
65a87a7 to
59e94d5
Compare
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CartPresenterto handle missingid_address_deliveryandid_address_invoice.CartPresenterTest, adding mock initialization for currency, addresses, and gift wrapping functionality.OrderPayloadUtilityto provide detailed parameter structure.insurance,shipping_discount) inAmountBreakdownNodeTestfor completeness.BodyValuesValidatorTestto validate new webhook parameters (eventStream,eventNumber,webhookId).UpdateExternalPayPalOrderProcessorTestto streamline logic.Self-Checks
JIRA task link
Resolves: XXXX
Summary
QA Checklist Labels
QA Checklist
Additional Context
Frontend Changes
[!] Don't forget to include JIRA task number in PR name or branch name. [!]
[!] Don't forget to update changelog.md with new changes. [!]