After install, the getAvailableTemplates() method , scandir find .php…#16
Open
WebHelpersPau wants to merge 1 commit intoPrestaShopCorp:devfrom
Open
After install, the getAvailableTemplates() method , scandir find .php…#16WebHelpersPau wants to merge 1 commit intoPrestaShopCorp:devfrom
WebHelpersPau wants to merge 1 commit intoPrestaShopCorp:devfrom
Conversation
… files When running scandir, the method getAvailableTemplates() get not only . and .. files, but also index.php This results in a warning about open_base_dir restrictions if set when running the following get_file_contents() Warning à la ligne 41 du fichier /var/www/PRESTASHOP/override/modules/ps_emailsmanager/ps_emailsmanager.php [2] file_exists(): open_basedir restriction in effect. File(/var/www/PRESTASHOP/modules/ps_emailsmanager/imports/index.php/settings.json) is not within the allowed path(s): (/var/www/PRESTASHOP:/tmp)
|
Hi @WebHelpersPau, you're PR seems valid to me! Can you specify a How to test so the QA team can easily check that your PR is doing what is expected? :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… files
When running scandir, the method getAvailableTemplates() get not only . and .. files, but also index.php
This results in a warning about open_base_dir restrictions if set when running the following get_file_contents()
Warning à la ligne 41 du fichier /var/www/PRESTASHOP/override/modules/ps_emailsmanager/ps_emailsmanager.php
[2] file_exists(): open_basedir restriction in effect. File(/var/www/PRESTASHOP/modules/ps_emailsmanager/imports/index.php/settings.json) is not within the allowed path(s): (/var/www/PRESTASHOP:/tmp)