Fix/runcatching coroutine cancellation#1046
Merged
Merged
Conversation
AleksandarIlic
previously approved these changes
May 5, 2026
The custom runCatching helpers in core/utils caught Throwable, which silently absorbed CancellationException and broke structured concurrency. Rethrow CancellationException explicitly so cancellation propagates as the framework expects; also restores correct behavior for downstream combinators (mapCatching, alsoCatching, recoverCatching) that delegate to runCatching, and fixes withTimeout enforcement at sites that wrap runCatching inside a timeout block.
Introduces a new :detekt-rules subproject that ships two rules in the PrimalRuleSet: - RequireCustomRunCatching: flags any runCatching(...) call in a file that does not import net.primal.core.utils.runCatching, preventing future use of the stdlib variant which silently swallows CancellationException. - RequireCustomResult: flags any Result<...> type reference or Result.success/.failure call in a file that does not import the custom net.primal.core.utils.Result.
markocic
force-pushed
the
fix/runcatching-coroutine-cancellation
branch
from
d86a9f9 to
bc7a1aa
Compare
AleksandarIlic
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.