Skip to content

enhanced type annotations - Update firehose_server.jl #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xylontronix wants to merge 1 commit into
base: main
Choose a base branch
from
Open

enhanced type annotations - Update firehose_server.jl #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/firehose_server.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ import JSON
import ..Utils
using ..Utils: ThreadSafe, wait_for

const HOST = Ref("127.0.0.1")
const PORT = Ref(9000)
const HOST::Ref{String} = Ref("127.0.0.1")
const PORT::Ref{Int} = Ref(9000)

const PRINT_EXCEPTIONS = Ref(true)

Expand All @@ -26,7 +26,7 @@ const latest_exceptions = ThreadSafe(CircularBuffer(50))

const message_processors = ThreadSafe(SortedDict{Symbol, Function}())

isactive() = !isnothing(server[])
isactive()::Bool = !isnothing(server[])

function start()
@assert isempty(connections)
Expand Down Expand Up @@ -93,7 +93,7 @@ function stop()
@info "stopped message firehose server on port $(PORT[])"
end

function start_reader_task(sock)
function start_reader_task(sock::TCPSocket)
errormonitor(@async begin
while isactive() && isopen(sock) && isreadable(sock)
s = readline(sock)
Expand Down Expand Up @@ -126,7 +126,7 @@ function start_reader_task(sock)
end)
end

function broadcast(msgs::Vector{String}) # it's better to use broadcast_via_channel
function broadcast(msgs::Vector{String})::Nothing # it's better to use broadcast_via_channel
lock(latest_sent_messages) do lmsgs
for msg in msgs
push!(lmsgs, msg)
Expand Down