fix(checkbox): resolve problem with the style of the Checkbox component where there was no response to state change#145
Open
mbalabash wants to merge 1 commit into
Conversation
…nt where there was no response to state change
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a visual bug in the Checkbox component where styles were not updating in response to state changes, specifically when the checkbox is checked, focused, or active.
- Adds CSS styles for checked, checked:active, and checked:focus states using CSS variables for theming
- Updates the package version from 2.2.4 to 2.2.5
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/components/Checkbox/Checkbox.module.scss | Adds state-specific styles for checked checkbox states using theme variables |
| package.json | Version bump to 2.2.5 reflecting the bug fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey!
Currently, the styles of the Checkbox component do not update in response to its state changes:
before.mov
This update introduces theme-specific styles that handle state transitions:
after.mov