fix: pressing esc should close confirmation modal#152
Open
0x6A6471 wants to merge 2 commits into
Open
Conversation
moysa
force-pushed
the
dev
branch
2 times, most recently
from
664fa03 to
b8b397e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #151
Context
The issue occurs because the Escape key event bubbles from the modal's Dialog component to the parent
EditBoxcomponent'sonEscapehandler, which then re-triggers thecloseEditorfunction, reopening the confirm modal in an endless loop.The fix involves adding a signal in
EditBoxto track when the modal was just closed via Escape, preventing the re-trigger in theonEscapehandler. This ensures the modal closes cleanly without the continuous open/close cycle.