Support for using step level advantages from verifiers#1838
Closed
Support for using step level advantages from verifiers#1838
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Resolve CHANGELOG.md conflict by keeping both branch entries. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for reading verifiers defined step level advantages. In order for prime-rl to read these, we need:
completion_advantagesneeds to be the same length ascompletion_idsif any of those aren't set/fail, we fallback to distributing the prime-rl calculated advantage to each token
Note
Medium Risk
Touches the RL training data path (transport schema + advantage packing), so mismatched lengths or missing fields could break training; safeguards exist via validation/asserts and fallback behavior.
Overview
Adds optional support for verifier-provided step/per-token advantages via new
orchestrator.use_verifier_step_advantagesconfig, plus plumbing to request ause_verifiers_advantagesstate column in rollout generation.When enabled and verifier data is present/valid,
interleave_rolloutpopulatesTrainingSample.completion_advantagesfrom per-stepcompletion_advantages(padding prompt-in-completion segments with zeros); otherwise the orchestrator backfillscompletion_advantagesby repeating the computed rollout advantage per token. This also replaces the transport fieldadvantagewithcompletion_advantages, updates batch packing to consume per-token advantages (prompt tokens forced to 0), and adjusts/extends unit tests accordingly.Written by Cursor Bugbot for commit 2e94744. This will update automatically on new commits. Configure here.