Open
Conversation
Owner
PrimeNumb
commented
Oct 4, 2022
PrimeNumb
commented
- Optimized Pngwriter slightly
- Added tests to increase coverage in image.py
- Fixed a bug where pdf2txt.py would not convert PDFs properly
Added tests to increase coverage in image.py
danielgholiof
approved these changes
Oct 6, 2022
yang-uu
requested changes
Oct 6, 2022
| bmp = BMPWriter(fp, 8, 10, 10) | ||
| bmp.write_line(0, b'0') | ||
| fp.close() | ||
| self.assertTrue(os.path.isfile(filename)) |
Collaborator
There was a problem hiding this comment.
This is always true regardless of what BMPWriter do, right? Then would you add an assertion of the file content
Owner
Author
There was a problem hiding this comment.
Don't think we have access to a BMP parser, no time to write one
Owner
Author
There was a problem hiding this comment.
Actually a BMP parser would file it as corrupted because technically speaking the content is not valid for a BMP, we're only testing if it can output anything at all
Collaborator
There was a problem hiding this comment.
alright, in that case i agree that's the best you can do. thanks for the clarification!
yang-uu
approved these changes
Oct 6, 2022
| bmp = BMPWriter(fp, 8, 10, 10) | ||
| bmp.write_line(0, b'0') | ||
| fp.close() | ||
| self.assertTrue(os.path.isfile(filename)) |
Collaborator
There was a problem hiding this comment.
alright, in that case i agree that's the best you can do. thanks for the clarification!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.