Conversation
Collaborator
Author
|
Something is wrong with the ci, getting error "package 'libhdf5-103' has no installation candidate" |
Collaborator
|
Yep, I have a PR #222 that fixes this (newest version of ubuntu does not provide the older hdf5 version that the workflow had hard-coded). Give it a look and approve it, then I will merge... |
smiet
reviewed
Apr 3, 2025
Collaborator
smiet
left a comment
smiet
left a comment
There was a problem hiding this comment.
LGTM, let us run the tests to be sure. You can merge the fixed branch into this one to get them to run correctly.
$ git pull
$ git merge remove_findFFTW
$git push
should do the trick
Collaborator
Author
|
Works well now, thanks for the help :) |
smiet
approved these changes
Apr 4, 2025
Collaborator
smiet
left a comment
smiet
left a comment
There was a problem hiding this comment.
LGTM! Now that it passes the regression tests I am happy to approve
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.