Skip to content

"Coupling Integral 1" test#1671

Merged
lsawade merged 2 commits intoPrincetonUniversity:develfrom
int-ptr-ptr:nci-bdintegral1
Mar 3, 2026
Merged

"Coupling Integral 1" test#1671
lsawade merged 2 commits intoPrincetonUniversity:develfrom
int-ptr-ptr:nci-bdintegral1

Conversation

@int-ptr-ptr
Copy link
Copy Markdown
Collaborator

Description

Please describe the changes/features in this pull request.

  • adds test to the first coupling integral in the same vein as the second coupling integral test.

Issue Number

If there is an issue created for these changes, link it here

#1342

Checklist

Please make sure to check developer documentation on specfem docs.

  • I ran the code through pre-commit to check style
  • THE DOCUMENTATION BUILDS WITHOUT WARNINGS/ERRORS
  • I have added labels to the PR (see right hand side of the PR page)
  • My code passes all the integration tests
  • I have added sufficient unittests to test my changes
  • I have added/updated documentation for the changes I am proposing
  • I have updated CMakeLists to ensure my code builds
  • My code builds across all platforms

@int-ptr-ptr int-ptr-ptr requested review from icui and lsawade February 26, 2026 17:12
@int-ptr-ptr int-ptr-ptr mentioned this pull request Mar 2, 2026
8 tasks
@lsawade lsawade requested a review from Rohit-Kakodkar March 2, 2026 15:48
Copy link
Copy Markdown
Collaborator

@lsawade lsawade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@int-ptr-ptr int-ptr-ptr linked an issue Mar 2, 2026 that may be closed by this pull request
2 tasks
@lsawade lsawade merged commit 714b672 into PrincetonUniversity:devel Mar 3, 2026
8 checks passed
@int-ptr-ptr int-ptr-ptr deleted the nci-bdintegral1 branch March 4, 2026 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test for Integrate 1D

4 participants