Update the gradient algorithm to return the jacobian if the callable#1681
Closed
Update the gradient algorithm to return the jacobian if the callable#1681
Conversation
…input has poitnjacbina as argument.
Collaborator
Author
|
Will be addressed differently: See #1710 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reopening, since performance is definitely improved by this. I isolated this changed. So, maybe the Jacobian is not kept in L1 Cache. Improvement is 3.8 to 3.6 seconds in fluid-solid-interface run.
Putting it here again for proper benchmarking.
Issue Number
-/-
Checklist
Please make sure to check developer documentation on specfem docs.