Skip to content

Issue 1579 - Add conforming interface for dim3#1685

Merged
icui merged 3 commits intodevelfrom
issue-1579
Mar 6, 2026
Merged

Issue 1579 - Add conforming interface for dim3#1685
icui merged 3 commits intodevelfrom
issue-1579

Conversation

@icui
Copy link
Copy Markdown
Collaborator

@icui icui commented Mar 3, 2026

Description

Add conforming interface

Issue Number

Closes #1579

Checklist

Please make sure to check developer documentation on specfem docs.

  • I ran the code through pre-commit to check style
  • THE DOCUMENTATION BUILDS WITHOUT WARNINGS/ERRORS
  • I have added labels to the PR (see right hand side of the PR page)
  • My code passes all the integration tests
  • I have added sufficient unittests to test my changes
  • I have added/updated documentation for the changes I am proposing
  • I have updated CMakeLists to ensure my code builds
  • My code builds across all platforms

@icui icui requested review from Rohit-Kakodkar and lsawade March 4, 2026 04:03
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test needs to be enabled right?

@Rohit-Kakodkar Rohit-Kakodkar self-requested a review March 6, 2026 15:32
@icui icui merged commit 83f3147 into devel Mar 6, 2026
8 checks passed
@icui icui deleted the issue-1579 branch March 6, 2026 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants