chore: float64 -> float32 in process_text_na_dataframe#926
Draft
ggprior wants to merge 1 commit into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies the process_text_na_dataframe function in src/tabpfn/preprocessing/clean.py to cast the output to float32 instead of float64. Feedback indicates that this change introduces numerical stability risks, contradicts the function's docstrings, and creates inconsistencies with the rest of the preprocessing pipeline which defaults to float64.
| X_encoded[:, string_cols_ix], | ||
| ) | ||
| return typing.cast("np.ndarray", X_encoded.astype(np.float64)) | ||
| return typing.cast("np.ndarray", X_encoded.astype(np.float32)) |
Contributor
There was a problem hiding this comment.
Changing the return type to float32 introduces several inconsistencies:
- Numerical Stability:
src/tabpfn/constants.py(lines 50-51) definesDEFAULT_NUMPY_PREPROCESSING_DTYPEasnp.float64specifically to avoid overflows during transformations like Yeo-Johnson. Hardcodingfloat32here may lead to issues in subsequent preprocessing steps. - Docstring Inconsistency: The docstring for
process_text_na_dataframe(lines 142 and 145) still explicitly mentions conversion tofloat64. - Pipeline Inconsistency:
fix_dtypes(line 69) defaults tofloat64. Sinceclean_datacalls both, thenumeric_dtypesetting infix_dtypesis now effectively overridden by this hardcodedfloat32cast.
If the intention is to move the pipeline to float32, consider updating the global constant or making the dtype a parameter to maintain consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.