chore: add THIRD-PARTY-NOTICES.md#964
Merged
Merged
Conversation
Document third-party code adapted into this repository with upstream attribution. Mirrors the format used in fomo-fitting. Surfaced during pre-submission self-scan for the BearingPoint code review. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
noahho
requested review from
Copilot and
priorphil
and removed request for
a team
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a THIRD-PARTY-NOTICES.md file to document third-party code adapted into the repository. The reviewer suggested updating the summary table and the local path descriptions to correctly include the Torch implementation of the SquashingScaler for better accuracy and completeness.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a top-level third-party notices document to track vendored/adapted upstream code and its attribution, aligning the repo with compliance expectations for externally sourced code.
Changes:
- Add
THIRD-PARTY-NOTICES.mdwith a summary table of adapted upstream code. - Document the skrub
SquashingScaleradaptation and provide contributor guidance for future entries.
Comments suppressed due to low confidence (2)
THIRD-PARTY-NOTICES.md:6
- The statement about “Transitive dependencies … (see
pyproject.tomlfor the canonical list)” is inaccurate:pyproject.tomlonly lists direct/project dependencies, not the full resolved/transitive set. Consider rewording to distinguish direct deps vs transitive deps, and (if you want a canonical resolved list) point to whatever lockfile / license-audit output the project actually uses.
upstream attribution preserved. Transitive dependencies installed via
`pip` are governed by their own licenses (see `pyproject.toml` for the
canonical list).
THIRD-PARTY-NOTICES.md:26
- For the skrub entry, the notice currently records only the SPDX identifier (BSD-3-Clause). For BSD-3-Clause redistribution compliance you typically need to reproduce the full license text and copyright notice in the distribution (or vendor the upstream LICENSE/NOTICE file). Consider either embedding the relevant BSD-3-Clause text + copyright holder(s) here, or adding a vendored
LICENSE/NOTICEfile for skrub and referencing its local path in this notice.
### skrub — SquashingScaler
**Upstream:** https://github.com/skrub-data/skrub
**Local path:** `src/tabpfn/preprocessing/steps/squashing_scaler_transformer.py`
**License:** BSD-3-Clause
**Modifications:** Adapted to fit TabPFN's preprocessing pipeline; algorithmic logic preserved.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Add upstream copyright lines to adapted source files (skrub, lucidrains rotary-embedding-torch). Upstream projects don't ship per-file headers, so we add an inline attribution block citing the upstream URL, copyright holder, and SPDX identifier. - Update NOTICE entries to include the upstream copyright lines. - Clarify the "Adding new entries" policy to distinguish whole-directory vendoring (vendor LICENSE alongside) from single-file adaptation (in-file attribution + NOTICE is sufficient). Same pattern just applied in tabpfn-time-series#129 in response to a gemini-code-assist review. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- Add `torch_squashing_scaler.py` to the NOTICE entry; it is a PyTorch port of the same skrub-derived algorithm. Attribution block added to the source file (PriorLabs copyright preserved + skrub credit + SPDX). - Add changelog fragment for #964. Addresses gemini-code-assist review feedback and fixes the "Check Changelog" CI gate. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
THIRD-PARTY-NOTICES.mddocumenting third-party code adapted or copied into this repository, with upstream attribution preserved.Test plan
THIRD-PARTY-NOTICES.mdshows on repo landing page