Skip to content

Translate user-facing thinking_metric -> wire thinking_effort_metric #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggprior merged 1 commit into from
May 10, 2026
+4 −2
Merged

Translate user-facing thinking_metric -> wire thinking_effort_metric #272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/tabpfn_client/api_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ class FitRequest(BaseModel):
# Budget for the fit (seconds). Only consulted when `thinking_effort` is set.
thinking_timeout_s: Optional[float] = None
# Optimization metric for the fit. Only consulted when `thinking_effort` is set.
thinking_metric: Optional[str] = None
thinking_effort_metric: Optional[str] = None


class FitResponse(BaseModel):
Expand Down
4 changes: 3 additions & 1 deletion src/tabpfn_client/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,6 +407,8 @@ def fit(
# The client-side `thinking_*` knobs forward 1:1 to the server's
# top-level FitRequest fields. When the user enabled thinking via
# `thinking_mode=True` without picking a level, default to "medium".
# The user-facing kwarg is `thinking_metric`; on the wire it is sent
# as `thinking_effort_metric` (matching the server's FitRequest schema).
if thinking_enabled and tabpfn_config:
thinking_effort = tabpfn_config.get("thinking_effort") or "medium"
thinking_timeout_s = tabpfn_config.get("thinking_timeout_s")
Expand Down Expand Up @@ -444,7 +446,7 @@ def fit(
tabpfn_config=server_tabpfn_config,
thinking_effort=thinking_effort,
thinking_timeout_s=thinking_timeout_s,
thinking_metric=thinking_metric,
thinking_effort_metric=thinking_metric,
),
timeout=client_options.timeout,
headers=client_options.headers,
Expand Down
Loading