Fix kwargs not forwarded to SequentialFeatureSelector

[phil-c137]

kwargs passed to feature_selection() were never forwarded to SequentialFeatureSelector, making parameters like tol have no effect.

[chatgpt-codex-connector]

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug in the feature selection utility where additional keyword arguments intended for the SequentialFeatureSelector were not being passed through. This fix ensures that all relevant parameters are correctly applied during the feature selection process, improving the configurability and reliability of the interpretability module.

Highlights

• Bug Fix: kwargs Forwarding: Resolved an issue where keyword arguments passed to the _feature_selection function were not correctly forwarded to the SequentialFeatureSelector constructor, preventing parameters like tol from taking effect.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• src/tabpfn_extensions/interpretability/feature_selection.py
  • Forwarded kwargs to SequentialFeatureSelector constructor.

Activity

• No specific activity (comments, reviews, or progress updates) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[CLAassistant]

All committers have signed the CLA.

[gemini-code-assist]

Code Review

This pull request addresses a bug where keyword arguments were not being passed to SequentialFeatureSelector. The change correctly forwards these arguments. My feedback includes a suggestion to add validation for the passed arguments to prevent potential runtime errors and improve robustness.

[Copilot]

Pull request overview

This PR fixes feature_selection() so that arbitrary keyword arguments provided by callers are correctly forwarded to scikit-learn’s SequentialFeatureSelector, enabling parameters like tol to take effect.

Changes:

• Forward **kwargs from _feature_selection() into SequentialFeatureSelector(...).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.