fix: enforce 100-character max length on goal title (closes #384#463
Closed
MehtabSandhu11 wants to merge 2 commits into
Closed
fix: enforce 100-character max length on goal title (closes #384#463MehtabSandhu11 wants to merge 2 commits into
MehtabSandhu11 wants to merge 2 commits into
Conversation
|
@MehtabSandhu11 is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel. A member of the Team first needs to authorize it. |
GSSoC Label Checklist 🏷️@Priyanshu-byte-coder — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
Owner
|
Closing — the server-side validation here is a subset of what PR #469 already implements more thoroughly (full type checks, bounds, error handling). #469 has been merged. If you want to contribute the client-side character counter from this PR, please open a fresh PR against the updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Neither the frontend input nor the
POST /api/goalsendpoint validated the length of the goal title. A very long title would be stored in the database and overflow the progress bar card layout, breaking the UI.Changes
src/app/api/goals/route.tsPOSThandler: returns400with a descriptive error iftitle.trim().length > 100src/components/GoalTracker.tsxmaxLength={100}to the title<input>as a browser-level hard stop{n}/100) that turns red at 90+ characters to warn the user before they hit the limithandleCreate()to block submission without a network round-tripdisabledcondition to also block when a title error is presentaria-describedbyon the input pointing to the hint/counter element for accessibilityBehaviour
400 Bad Requestwith error messageTesting
POSTrequest directly to/api/goalswith a 101-character title — returns400npm run lint && npm run type-checkpass with no new errorsPlease apply the appropriate labels so that I can get the GSSoC points.