feat:animations applied only on divs#573
Open
Saqlain532 wants to merge 1 commit into
Open
Conversation
|
@Saqlain532 is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel. A member of the Team first needs to authorize it. |
GSSoC Label Checklist 🏷️@Priyanshu-byte-coder — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
Priyanshu-byte-coder
requested changes
May 21, 2026
Owner
Priyanshu-byte-coder
left a comment
There was a problem hiding this comment.
Missing EOF newline at the end of src/app/globals.css. Please add a newline after the .fade-up block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As the previous branch was too messy to making rebase with original repo . So i created new branch and upstreamed with original repo then I have changed only required file that i.e global.css and src/page.tsx .
Closes #343
Type of Change
Changes Made
I have applied animation on divs using @Keyframes in global.css .
applied same calssName to sign with github and view on github div for consistent look .
I have take care about the hardcoded color and applied suggesation to replace hard coded color with { bg-white text-slate-900 on the GitHub sign-in button → use bg-[var(--card)] text-[var(--card-foreground)]
hover:bg-slate-100 on both buttons → use hover:bg-[var(--control)] }
as mentioned in my first PR #395
How to Test
Steps for the reviewer to verify this works:
1.Clone the branch and install dependencies using npm install
2.Run the development server using npm run dev
3.Open the main page in the browser
4.Hover over interactive sections/cards and verify:
i> background color transition
iii> smooth scale animation
5.Run npm run lint to verify no lint issues in the modified code
Checklist
npm run lintpasses locallynpm run type-check)