[SP-76] Fix Cloudflare containers

[zotabee]

• Fix cloudflare-ddns container (migrate to favonia/cloudflare-ddns as oznu/cloudflare-ddns is dead and repo archived) + docker api bug
• Change env var as per favonia/cloudflare-ddns doc
• Linting via yamllint and ansible-lint (production)

[zotabee]

The role and the docker containers are working with this PR but unfortunately, there is a problem with the upstream project (favonia/cloudflare-ddns) related to the API token to authenticate to Cloudflare.

favonia/cloudflare-ddns#983
favonia/cloudflare-ddns#1043
favonia/cloudflare-ddns#1053

It doesn't seem as maintained as wished sadly.

Couldn't find a fork of oznu/cloudflare-ddns (as with timothymiller/cloudflare-ddns) that is actively maintained and would work with the recent Docker API changes these past couple months and that won't be dead in few months.

Else there are other Cloudflare DDNS projects that we could consider.

[favonia]

Hi @zotabee, sorry for the intrusion. I am the author of cloudflare-ddns. You are right that I have not been actively maintaining it for the past two years due to a long-term health issue.

From what I can tell, the linked issues should be resolved now, but I may be missing something. I left them open mainly because I still want to update the documentation and confirm there are no remaining edge cases.

If cloudflare-ddns is still failing for you, I would really appreciate a log (with secrets redacted). Even if you decide to switch tools, the details would help me check the current behavior and improve the docs.

Thanks again for taking the time to evaluate it.

[zotabee]

Hi @favonia, thank you so much for reaching out, and please, there is absolutely no need to apologize.

I am very sorry to hear about your health issues. Personal well-being always comes first, especially over open-source maintenance. I really appreciate the work you put into cloudflare-ddns. Please take care of yourself!

And you are totally right, it's resolved! I was still using the API key (not the API token), as it's clearly written in Step 1 section :

Click to expand: 🔑 CLOUDFLARE_API_TOKEN is your Cloudflare API token

The value of CLOUDFLARE_API_TOKEN should be an API token (not an API key), which can be obtained from the API Tokens page. Use the Edit zone DNS template to create a token. The less secure API key authentication is deliberately not supported.

I only read the "Migration Guides / I am migrating from oznu/cloudflare-ddns" section when I setup it initially,

Old Parameter		Note
API_KEY=key	✔️	Use CLOUDFLARE_API_TOKEN=key

Somehow oznu choosed to name its env var "API_KEY" even though he talks about a scoped API token in the different description and steps. (We were using the API key with his project, and it worked.)

So that's where the confusion came from. And with the issues that were open above, I mistakenly thought it was a problem upstream.

So all fixed! Many thanks again!

I will commit and push the fix here.

PS: I rolled the token until I got one without any special characters (no "-") as stated in your issues, to avoid the edge cases. Let me know if you want me to do some tests for you.

[favonia]

Thanks for the feedback. The guide should be improved.

EDIT: the guide was updated.