add node manager to make nodes peer-stoppable#10
Merged
Conversation
XuhuiZhou
requested changes
Dec 5, 2024
Collaborator
XuhuiZhou
left a comment
XuhuiZhou
left a comment
There was a problem hiding this comment.
Consider adding a doc for how to use this?
XuhuiZhou
requested changes
Dec 13, 2024
| #### Experimental feature: Peer-stopping | ||
|
|
||
| An experimental feature is peer-stopping. A node can not only stop itself but also other nodes. To do this, send | ||
| a message to the channel `f"shutdown:{self.node_name}"` and the node manager will shutdown all of the nodes in the |
Collaborator
There was a problem hiding this comment.
this sentence does not seem to make sense, a specific name and all?
f"shutdown:{self.node_name}" and the node manager will shutdown all of the nodes
Owner
Author
There was a problem hiding this comment.
Yeah, the channel name is meant to indicate where the shutdown signal comes from. And right now, I only implemented shutdown all nodes function. Do you think this is enough for your use case?
Collaborator
There was a problem hiding this comment.
Yes, that should work, it's just the sentence is a little bit ambigous
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.