Fixing Ansible warnings with updated syntax and other fixes.

ansible/roles/ubuntu-apache/tasks/main.yml

@@ -7,7 +7,9 @@
     - apache2-utils
 
 - name: ensure apache service is stopped
-  shell: service apache2 stop
+  service:
+    name: apache2
+    state: stopped
 
 - name: fix default apache vhost
   copy:
@@ -89,4 +91,6 @@
     group: 'root'
 
 - name: ensure apache service is started
-  shell: service apache2 start
+  service:
+    name: apache2
+    state: started

ansible/roles/ubuntu-base/tasks/ntp.yml

@@ -1,7 +1,12 @@
 ---
 
-- name: install ntp
-  apt: name=ntp state=present
+- name: install ntp apt package.
+  apt:
+    name: ntp
+    state: present
 
-- name: make sure ntp is started up
-  service: name=ntp state=started enabled=yes
+- name: ensure ntp service is started
+  service:
+    name: ntp
+    state: started
+    enabled: yes

ansible/roles/ubuntu-mysql/tasks/main.yml

@@ -5,8 +5,10 @@
   with_items:
     - 'mysql-server'
 
-- name: start mysql service
-  shell: service mysql start
+- name: ensure mysql service is started
+  service:
+    name: mysql
+    state: started
 
 - name: install mysql python extension for ansible
   apt: name=python-mysqldb state=present
@@ -35,5 +37,7 @@
 - name: add my.cnf file for root
   template: src=my.cnf.j2 dest=/root/.my.cnf owner=root mode=0600
 
-- name: ensure mysql is stopped
-  shell: service mysql stop
+- name: ensure mysql service is stopped
+  service:
+    name: mysql
+    state: stopped

ansible/roles/ubuntu-nodejs-6.x/tasks/main.yml

@@ -25,7 +25,7 @@
     name: nodejs
     state: present
   register: installnodejs
-  until: installnodejs | success
+  until: installnodejs is success
 
 - name: Install "bower" node.js package globally.
   npm:

ansible/roles/ubuntu-nodejs-8.x/tasks/main.yml

@@ -25,7 +25,7 @@
     name: nodejs
     state: present
   register: installnodejs
-  until: installnodejs | success
+  until: installnodejs is success
 
 - name: Install "bower" node.js package globally.
   npm:

ansible/roles/ubuntu-nodejs/tasks/main.yml

@@ -25,7 +25,7 @@
     name: nodejs
     state: present
   register: installnodejs
-  until: installnodejs | success
+  until: installnodejs is success
 
 - name: Install "bower" node.js package globally.
   npm:

ansible/roles/ubuntu-php-5.6/tasks/main.yml

@@ -49,7 +49,7 @@
     name: memcached
     state: present
 
-- name: craete php log dir
+- name: create php log dir
   file:
     path: /var/log/php
     state: directory

ansible/roles/ubuntu-postgres/tasks/main.yml

@@ -6,15 +6,19 @@
     - 'postgresql'
     - 'postgresql-contrib'
 
-- name: start postgres service
-  shell: service potsgres start
+- name: ensure postgres service is started
+  service:
+    name: postgres
+    state: started
 
 - name: create base postgres db
   postgresql_db:
-  name: acme
+    name: acme
 
 - name: add postgres.cnf file for root
   template: src=postgres.cnf.j2 dest=/root/.postgres.cnf owner=root mode=0600
 
-- name: ensure postgres is stopped
-  shell: service postgres stop
+- name: ensure postgres service is stopped
+  service:
+    name: postgres
+    state: stopped

ansible/roles/ubuntu-probo/tasks/solr.yml

@@ -47,11 +47,15 @@
     group: root
     mode: 0755
 
-- name: Start solr service.
-  command: service solr start
+- name: ensure solr service is started
+  service:
+    name: solr
+    state: started
 
 - name: Create default solr instance.
   command: create-solr-instance solr /opt/solr/server/solr/configsets/search_api_solr_8.x-1.0
 
-- name: Stop solr service.
-  command: service solr stop
+- name: ensure solr service is stopped
+  service:
+    name: solr
+    state: stopped

ansible/roles/ubuntu-varnish/tasks/main.yml

@@ -6,7 +6,9 @@
     state: present
 
 - name: ensure varnish service is stopped
-  shell: service varnish stop
+  service:
+    name: varnish
+    state: stopped
 
 - name: setup drupal default.vcl
   copy:
@@ -27,4 +29,4 @@
     src: secret
     dest: /etc/varnish/secret
     owner: root
-    mode: 0600
+    mode: 0600