FOUR-26848: Improve Message Catch and Throw Events Elements to configure the payload - Modeler - #1948
Closed
rodriquelca wants to merge 12 commits into
Closed
FOUR-26848: Improve Message Catch and Throw Events Elements to configure the payload - Modeler#1948rodriquelca wants to merge 12 commits into
rodriquelca wants to merge 12 commits into
Conversation
…ure the payload - Modeler
modeler
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Project |
modeler
|
| Branch Review |
feature/FOUR-26848
|
| Run status |
|
| Run duration | 02m 00s |
| Commit |
|
| Committer | Rodrigo Quelca |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
6
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
71
|
Passing
|
0
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
IntermediateMessageThrowEvent.cy.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Intermediate Message Throw Event > can render an intermediate message throw event |
Test Replay
Screenshots
|
|
Modeler.cy.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Modeler > Create a simple process |
Test Replay
Screenshots
|
|
Pools.cy.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Pools > Update pool name |
Test Replay
Screenshots
|
|
MessageFlows.cy.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Message Flows > Can connect two pools with a message flow |
Test Replay
Screenshots
|
|
DataObjectDataStore.cy.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Data Objects and Data Stores > does not support connecting sequence flows for processmaker-modeler-data-object |
Test Replay
Screenshots
|
|
The first 5 failed specs are shown, see all 94 specs in Cypress Cloud.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
| const validId = id.match(/^[_A-Za-z][-._A-Za-z0-9]*$/); | ||
| if (!validId) { | ||
| return this.$t('Data input ID is not a valid xsd:ID'); | ||
| } |
There was a problem hiding this comment.
Bug: Inconsistent Regex Validation Causes ID Conflicts
The DataInputAssociation component uses two different regex patterns for data input ID validation. One pattern allows only letters, numbers, and underscores, while the other also permits hyphens and dots. This inconsistency can lead to situations where a data input ID is saved but then incorrectly flagged as invalid in the display list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue & Reproduction Steps
Expected behavior:
Actual behavior:
Solution
How to Test
Test the steps above
Related Tickets & Packages
Code Review Checklist