FOUR-27993: Mobile > Processes view is not working correctly#8617
FOUR-27993: Mobile > Processes view is not working correctly#8617
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| }, | ||
| hideMenu(value) { // value is the new value of the menu | ||
| this.showMenu = value; | ||
| this.showMenu = !this.showMenu; |
There was a problem hiding this comment.
Bug: hideMenu emits stale value after toggling showMenu
The hideMenu method now toggles showMenu with !this.showMenu but still emits sizeChanged with the old value parameter. Since hideMenu is called from a click handler without arguments, value is undefined. The emitted event should reflect the new state of showMenu, not the undefined parameter.
| this.userConfiguration.launchpad.isMenuCollapse = this.showMenu; | ||
| if(this.userConfiguration?.launchpad) { | ||
| this.userConfiguration.launchpad.isMenuCollapse = this.showMenu; | ||
| } |
There was a problem hiding this comment.
Bug: Menu show/collapse state semantics inverted
The defineUserConfiguration method assigns isMenuCollapse directly to showMenu, but these have opposite meanings. When isMenuCollapse is true (menu is collapsed), showMenu should be false (menu not shown). Similarly, updateUserConfiguration assigns showMenu to isMenuCollapse, creating the same inversion. The values should be negated: this.showMenu = !this.userConfiguration?.launchpad?.isMenuCollapse in defineUserConfiguration and this.userConfiguration.launchpad.isMenuCollapse = !this.showMenu in updateUserConfiguration.
|
QA server K8S was successfully deployed https://ci-7db5b5180e.engk8s.processmaker.net |
|
|
Team, |
5 participants
Related Tickets & Packages
Code Review Checklist
ci:deploy
Note
Introduces a sliding MobileDrawer for small screens and updates ProcessesCatalogue to use it with safer menu state/config handling.
MobileDrawer.vue: New mobile sliding drawer with overlay, positional slide transitions,v-modelsupport, and open/close events.ProcessesCatalogue.vue: Switches menu container to dynamic component (mobile-draweron mobile,collapsable-containeron desktop) with responsive classes and left/right positioning.showMenuon control click; improves config access with optional chaining and guarded updates.MenuCatologuecontainer classes for full-size white panel on mobile.base/ui/index.js: ExportsMobileDrawer.Written by Cursor Bugbot for commit dae6eed. This will update automatically on new commits. Configure here.