Conversation
9fb1cd8 to
adc62dd
Compare
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on February 21
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| failOnDeprecation="false" | ||
| failOnRisky="false" | ||
| failOnIncomplete="false" | ||
| failOnSkipped="false" |
There was a problem hiding this comment.
Test configuration suppresses warnings, deprecations, and risky tests
Low Severity
The PHPUnit configuration now sets failOnWarning, failOnDeprecation, failOnRisky, failOnIncomplete, and failOnSkipped all to false. This combination significantly reduces the test suite's ability to catch issues. Most notably, failOnRisky="false" allows tests without assertions to pass silently, and failOnDeprecation="false" hides usage of deprecated code. While this may ease the PHPUnit version migration, these settings could mask real problems and may warrant a follow-up to restore stricter settings once the migration is stable.





Fixing this issue
Note
Low Risk
Changes are limited to dev/test dependencies and test runner behavior; main application runtime logic is unaffected, with the primary risk being reduced CI signal due to relaxed PHPUnit failure conditions.
Overview
Moves the dev test dependency from
phpunit/phpunit^12to^11.5.50, updatingcomposer.lockaccordingly (including related PHPUnit/sebastian package graph changes and updatednikic/php-parser/theseer/tokenizerconstraints).Updates
phpunit.xmlto disable failing the run on warnings, deprecations, risky/incomplete/skipped tests.Hardens
RedisMetricsManagerTest::tearDown()to only callresetMetrics()when$this->metricsis initialized, avoiding teardown errors when setup is skipped/aborted.Written by Cursor Bugbot for commit 880601b. This will update automatically on new commits. Configure here.