Skip to content

FOUR-21178: Navigation button shouldn't have the clipboard page as an option#1784

Closed
rodriquelca wants to merge 2 commits intorelease-2025-winterfrom
bugfix/FOUR-21178
Closed

FOUR-21178: Navigation button shouldn't have the clipboard page as an option#1784
rodriquelca wants to merge 2 commits intorelease-2025-winterfrom
bugfix/FOUR-21178

Conversation

@rodriquelca
Copy link
Contributor

Issue & Reproduction Steps

Expected behavior:
Navigation button shouldn't have the clipboard page as an option
Actual behavior:
Navigation button have the clipboard page as an option

Solution

  • add validation to not display a pageNavigate control by config
image

How to Test

  1. Test the steps above
  2. Access the Screen Builder
  3. Open a Form Screen
  4. Select a Navigation Button
  5. Configure where it should go
  6. Finde the Clipboard Page

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@cypress
Copy link

cypress bot commented Jan 21, 2025

screen-builder    Run #1710

Run Properties:  status check passed Passed #1710  •  git commit b844d018c3: FOUR-21178: Navigation button shouldn't have the clipboard page as an option
Project screen-builder
Branch Review bugfix/FOUR-21178
Run status status check passed Passed #1710
Run duration 09m 00s
Commit git commit b844d018c3: FOUR-21178: Navigation button shouldn't have the clipboard page as an option
Committer rodrigo
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 19
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 366
View all changes introduced in this branch ↗︎

@processmaker-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

});

it("TCP4-4443: Verify that the control from the NAVIGATION section have been added to the clipboard", () => {
it("TCP4-4443: Verify that the control from the NAVIGATION section have not been added to the clipboard", () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
it("TCP4-4443: Verify that the control from the NAVIGATION section have not been added to the clipboard", () => {
it("TCP4-4443: Verify the "Clipboard" button in NAVIGATION, but not "Clipboard" as a page option.");

event: 'pageNavigate',
eventData: null,

disableClipboard: true,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems the steps are not clear, but the problem is that the Clipboard appears as option in the destination screen:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants