Add the pgfopts package#63
Conversation
Setting up a test for this package seems extremely convoluted, the current minimalistic test just checks that all the dependencies are there, as is done for pgfcore.
|
I took a brief look at https://mirror.lyrahosting.com/CTAN/macros/latex/contrib/pgfopts/pgfopts.dtx but it doesn't seem easy to add a proper test. Or is it? I would rather not merge this PR without a proper test. Then probably no test will be made at all. |
|
I don't know of an easy way to test this either. I'm not using it directly, I'm just trying to get it in as a transitive dependency of another package I'm looking to use. |
|
Wouldn't it then be more logical to add |
|
I think the situation is the exact same as #67 - adding a new package isn't exactly trivial, especially when dependencies include fonts etc. Ultimately, it's the same discussion we had in #58 (comment). I totally understand that you don't want to maintain additional packages that you're not using though - I think it would be worth having a clear decision written somewhere on whether you want to accept third party contributions of new packages or not. It's a bit confusing having a bunch of packages defined in this repo, and then some PRs closed because you're not using them. (With that said, I'm well aware that this specific PR lacks tests, and I don't have an obvious solution to this.) |
|
To be honest, making sure people can use bazel-latex in its full glory is more important than the additional work of reviewing all PRs and merging them. Until I have a proper solution to this, it's best to just merge those PRs. I will add a CONTRIBUTING.md file as well. Hopefully, the number of packages doesn't become too big, which would cause the CI to take way too long. |
2 participants
No description provided.