Support thumb-style framed image embeds with visible captions#12
Merged
Conversation
Fixes #2 Adds an opt-in `thumb` keyword rendering a file embed as MediaWiki's framed thumbnail with the caption below the image, keeping inline rendering the default and leaving frame, frameless and alignment for later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2
Adds an opt-in
thumbkeyword rendering a file embed as MediaWiki's framed thumbnail with the caption below the image, keeping inline rendering the default and leaving frame, frameless and alignment for later.Known limitations (deferred, non-blocking):
[[File:X|thumb|Caption]]on its own line renders as<p><figure>...</figure></p>; browsers auto-close the paragraph so it displays correctly, but the nesting is invalid HTML. Promoting block-level embeds out of the paragraph is left for a follow-up.thumbrenders the upload link and drops the caption; non-inline media (audio, PDF) withthumbrenders as a plain file-page link.mediawiki.page.mediamodule is not loaded, so the client-side magnify affordance is absent; the server-rendered frame and caption are unaffected.Authored by Claude Code (
Opus 4.8 (max)) at Jeroen De Dauw's direction. Jeroen sets direction and reviews.