Help page per questionaire#61
Open
Darkshadenl wants to merge 12 commits into
Open
Conversation
MartijnAmbagtsheer
requested changes
Jun 15, 2022
| customTitle = `Hulp bij ${title.slice(title.indexOf('"') + 1, title.lastIndexOf('"'))}`; | ||
| } | ||
| }), | ||
| ParticipantCode.getCurrentQuestionaireHelp().then((h) => { |
Member
There was a problem hiding this comment.
Als je op de homescreen komt dan word je vragenlijst niet gereset dus op de homepagina hoort dit niet te verschijnen als je net uit een vragenlijst komt.
Contributor
There was a problem hiding this comment.
Dit kun je oplossen door in deze methode de vragenlijst te resetten
Contributor
Author
There was a problem hiding this comment.
@milovdpas idk hoe dat moet. Helppage checkt als je hem laadt of er een questionairetitle is. Als ie leeg is komt er geen extra stuk tekst bij. Dus ik vul in die return van jou een lege title in voor participantcode, maar hij runt dat stukje helemaal niet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #XX
Description
When no questionaire is loaded into the application, help page shows a general help page for Accessibility.
When Questionaire is present, help text gets loaded above standard help page.
Review focus
At the moment of writing this I just realised I haven't added accessibility helpers. Should be there in half an hour from opening this PR :).
Check the code, if anything can be improved (especially the way I use "ParticipantCode.ts") visually or on a coding level. Suggestions are appreciated.
Checklist
yarn formatyarn eslintand fixed any issuesA build will automatically be run by GitHub actions when any changes are made on this PR. This must complete successfully before merging.
Screenshots or videos