fix: change return type of nvml_to_cuda_map to int for consistency#130
fix: change return type of nvml_to_cuda_map to int for consistency#130xrwang8 wants to merge 3 commits into
Conversation
Signed-off-by: xrwang8 <xrwang8@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: xrwang8 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: xrwang8 <xrwang8@gmail.com>
Signed-off-by: xrwang8 <xrwang8@gmail.com>
|
Hi, We are going through open pull requests to keep things manageable. This PR was opened before 2026 and has not been merged or updated recently. Please reply by 2026-07-13 to confirm this is still relevant and based on the current codebase. If we do not hear back, we will close this PR. You are welcome to reopen it or submit a new one when ready. Thank you for your contribution to HAMi. |
Summary
This removes the implementation-defined behavior where an unsigned -1 could be interpreted as a huge positive index, bypassing the <0 guard and leading to out-of-bounds access when NVML devices are not
visible to CUDA (e.g., under CUDA_VISIBLE_DEVICES remapping).