Skip to content

docs: add contribution gates to AI assistance policy#216

Open
mesutoezdil wants to merge 1 commit into
Project-HAMi:mainfrom
mesutoezdil:docs/add-contribution-gates
Open

docs: add contribution gates to AI assistance policy#216
mesutoezdil wants to merge 1 commit into
Project-HAMi:mainfrom
mesutoezdil:docs/add-contribution-gates

Conversation

@mesutoezdil

@mesutoezdil mesutoezdil commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Ports the contribution gates from Project-HAMi/HAMi#2019 to HAMi-core so the same rules apply across the organization.

The new section adds six enforceable gates:

  1. Author-understanding gate: PR closed if author cannot explain their change when asked
  2. Hardware validation: required for device allocation and in-container isolation changes
  3. Scope and commit messages: no large AI-generated PRs; write your own commit messages
  4. Review replies: must be written by the author and address the specific point
  5. Commit trailer hygiene: no AI co-author trailers; disclosure in PR description only
  6. AI-generated comments: do not post filler or redundant AI-generated review comments

One adaptation: rule 2 drops the scheduler extender exception from the HAMi version, since HAMi-core has no scheduler component. Everything in this repo is device allocation or in-container isolation code, so hardware validation applies across the board.

Ref: Project-HAMi/HAMi#2019, Project-HAMi/HAMi#1998

Summary by CodeRabbit

  • Documentation
    • Added a new “Contribution Gates” section to the contribution guide.
    • Updated the table of contents to include the new section.
    • Clarified contribution expectations, including validation steps, commit message guidelines, review reply requirements, trailer formatting, and limits on AI-generated review comments.

@hami-robot

hami-robot Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mesutoezdil
Once this PR has been reviewed and has the lgtm label, please assign archlitchi for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hami-robot hami-robot Bot added the size/S label Jul 6, 2026
@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 64f46436-37ab-425f-a7f3-af197912784c

📥 Commits

Reviewing files that changed from the base of the PR and between 8f3a89c and 55a2bd3.

📒 Files selected for processing (1)
  • CONTRIBUTING.md

📝 Walkthrough

Walkthrough

CONTRIBUTING.md is updated to add a new table-of-contents entry and a "Contribution Gates" section describing six contribution rules covering author understanding, hardware validation, AI-assisted PR constraints, reviewer reply requirements, commit trailer hygiene, and restrictions on AI-generated review comments.

Changes

Contribution Gates documentation

Layer / File(s) Summary
Add Contribution Gates section and TOC link
CONTRIBUTING.md
Adds a table-of-contents entry and a new "Contribution Gates" section listing six numbered contribution rules for authors and AI-assisted contributions.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related issues

Poem

A rabbit hops through docs anew,
Adding gates for the AI crew,
Six rules typed, neat and small,
Guarding every pull request's call,
Thump-thump — CONTRIBUTING grows tall! 🐰📜

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the documentation update adding contribution gates for AI-assisted work.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Ports the contribution gates from Project-HAMi/HAMi#2019 to HAMi-core.
The hardware validation rule is kept without the scheduler extender
exception since HAMi-core has no scheduler component.

Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
@mesutoezdil mesutoezdil force-pushed the docs/add-contribution-gates branch from 6ac8579 to 55a2bd3 Compare July 6, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant