Skip to content

add tests for server#78

Merged
hami-robot[bot] merged 12 commits into
Project-HAMi:mainfrom
peachest:test/multi-cnt
May 27, 2026
Merged

add tests for server#78
hami-robot[bot] merged 12 commits into
Project-HAMi:mainfrom
peachest:test/multi-cnt

Conversation

@peachest

@peachest peachest commented May 15, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this?
/kind enhancement

What this PR does / why we need it:

split the too large server.go into serveral files and add tests for each

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@hami-robot

hami-robot Bot commented May 15, 2026

Copy link
Copy Markdown
Contributor

@peachest: The label(s) kind/enhancement cannot be applied, because the repository doesn't have them.

Details

In response to this:

What type of PR is this?
/kind enhancement

What this PR does / why we need it:

split the too large server.go into serveral files and add tests for each

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hami-robot hami-robot Bot requested review from DSFans2014 and archlitchi May 15, 2026 06:44
@hami-robot hami-robot Bot added the size/XL label May 15, 2026
@hami-robot hami-robot Bot added size/XXL and removed size/XL labels May 22, 2026
@peachest peachest force-pushed the test/multi-cnt branch 3 times, most recently from 2e3c6c2 to ed12cdb Compare May 22, 2026 07:44
@archlitchi

archlitchi commented May 22, 2026

Copy link
Copy Markdown
Member

please resolve the conflicts

houyuxi added 9 commits May 22, 2026 16:57
refactor(server): split server package into multiple files
b32e658 
Signed-off-by: houyuxi <yuxi.hou@transwarp.io>
refactor: extract Manager interface for testing
f4f8c99 
Signed-off-by: houyuxi <yuxi.hou@transwarp.io>
test(server): implement fake manager for testing
4499fd2 
Signed-off-by: houyuxi <yuxi.hou@transwarp.io>
test(server): add multiple tests
6844ff6 
Signed-off-by: houyuxi <yuxi.hou@transwarp.io>
ci: add test jobs
7f2d8a5 
Signed-off-by: houyuxi <yuxi.hou@transwarp.io>
fix: use devmanager.DeviceInterface
e704e9a 
Signed-off-by: houyuxi <yuxi.hou@transwarp.io>
ci: only test internal package
1170c3e 
Signed-off-by: houyuxi <yuxi.hou@transwarp.io>
ci: remove tidy in test job
40eccb2 
Signed-off-by: houyuxi <yuxi.hou@transwarp.io>
ci: remove coverage.out
d293ca2 
Signed-off-by: houyuxi <yuxi.hou@transwarp.io>
houyuxi added 2 commits May 26, 2026 12:46
fix(server): replace deprecated grpc.DialContext with grpc.NewClient
11c0365 
Signed-off-by: houyuxi <yuxi.hou@transwarp.io>
fix: lint issues
c8c8239 
Signed-off-by: houyuxi <yuxi.hou@transwarp.io>
ci: bump go version from 1.22.5 to 1.24.6
58062ec 
Signed-off-by: houyuxi <yuxi.hou@transwarp.io>
archlitchi
archlitchi approved these changes May 27, 2026
View reviewed changes

@archlitchi archlitchi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hami-robot hami-robot Bot added the lgtm label May 27, 2026
@hami-robot

hami-robot Bot commented May 27, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: archlitchi, peachest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hami-robot hami-robot Bot added the approved label May 27, 2026
@hami-robot hami-robot Bot merged commit a27ce4a into Project-HAMi:main May 27, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@archlitchi archlitchi archlitchi approved these changes

@DSFans2014 DSFans2014 Awaiting requested review from DSFans2014

Assignees

@archlitchi archlitchi

Labels

approved dco-signoff: yes lgtm size/XXL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@peachest @archlitchi