refactor: tighten proof style from Mathlib PR review feedback#11
Open
Nelson Spence (Fieldnote-Echo) wants to merge 1 commit intomainfrom
Open
refactor: tighten proof style from Mathlib PR review feedback#11Nelson Spence (Fieldnote-Echo) wants to merge 1 commit intomainfrom
Nelson Spence (Fieldnote-Echo) wants to merge 1 commit intomainfrom
Conversation
Apply lessons from three rounds of review on PR #36443: - .rfl over Iff.rfl, ext;simp for set equality, sub_pos.mpr for cast positivity - Unsqueeze terminal simp, squeeze non-terminal simp, omega over verbose lemmas - Drop deprecated `from` keyword, remove unused intermediates - Update CLAUDE.md with Mathlib reviewer conventions -35 lines of Lean, build + lint clean, zero sorry.
Nelson Spence (Fieldnote-Echo)
force-pushed
the
refactor/proof-style-cleanup
branch
from
2ebbdbb to
0765cd0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.rfloverIff.rfl,ext; simp [...]over manual constructor chains,sub_pos.mprfor cast positivity,omegaover verbose lemma applicationssimp only→simp, squeeze non-terminal baresimp→simp only, drop deprecatedfromkeywordlake build --wfail+lake lintclean, zero sorryTest plan
lake build --wfailpasses (1940 jobs)lake lintpasses (0 errors)🤖 Generated with Claude Code