Spectrodataset link rework#334
Merged
Gautzilla merged 6 commits intoProject-OSmOSE:mainfrom Feb 4, 2026
Merged
Conversation
mathieudpnt
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I reworked the
SpectroDataset.link_audio_dataset()method so that it now works if the AudioDataset contains more data than the SpectroDataset (providing all SpectroData of the sds can still be effectively linked to an AudioData of the ads):This last line raised an exception before as
len(ads.data] != len(sds.data).With this PR, the link will be done effectively as long as all spectro data have corresponding audio data in the ads to be linked.
Related issue
This PR resolves #333