Skip to content

Added disconnect client to the Websocket server#4

Merged
ProjectSky merged 2 commits intoProjectSky:mainfrom
CallMeVerity:main
Mar 26, 2025
Merged

Added disconnect client to the Websocket server#4
ProjectSky merged 2 commits intoProjectSky:mainfrom
CallMeVerity:main

Conversation

@CallMeVerity
Copy link
Copy Markdown
Contributor

@CallMeVerity CallMeVerity commented Mar 25, 2025

Added the ability to disconnect clients who are connected to your websocket server and implemented the GetClients function.

Allows you to disconnect clients who are connected to your websocket server.
@ProjectSky
Copy link
Copy Markdown
Owner

Thank you for your contribution. Before we proceed, could you please:

  1. Consolidate your commits - Currently there are 37 commits implementing just the DisconnectClient and GetClients features. Please rebase/squash them into meaningful atomic commits.
  2. Fix code indentation issues - Some files have inconsistent formatting.
  3. Update version definition - After these changes, please modify SMEXT_CONF_VERSION in smsdk_config.h as this defines release version.

Please resubmit after completing these adjustments. Appreciate your work!

@CallMeVerity
Copy link
Copy Markdown
Contributor Author

I've made the requested changes, including consolidating commits, fixing formatting, and updating the version. Let me know if anything else is needed.

@ProjectSky ProjectSky merged commit d02b86e into ProjectSky:main Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants