refactor: remove redundant observe_slice override#400
Open
GarmashAlex wants to merge 1 commit intoProjectZKM:mainfrom
Open
refactor: remove redundant observe_slice override#400GarmashAlex wants to merge 1 commit intoProjectZKM:mainfrom
GarmashAlex wants to merge 1 commit intoProjectZKM:mainfrom
Conversation
eigmax
force-pushed
the
main
branch
4 times, most recently
from
486cfe8 to
ce11d49
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DuplexChallengerVariable implementation of CanObserveVariable<Felt<_>> was manually overriding observe_slice with the same logic as the default method in the trait. This override did not change behavior or performance, but duplicated code and diverged from the pattern used by other CanObserveVariable implementations. By relying on the trait's provided observe_slice, we keep the challenger API simpler and avoid maintaining duplicated logic without introducing any functional changes.