fix: remove duplicate assert_bool constraints in ShiftRightChip#451
Open
eeemmmmmm wants to merge 1 commit intoProjectZKM:mainfrom
Open
fix: remove duplicate assert_bool constraints in ShiftRightChip#451eeemmmmmm wants to merge 1 commit intoProjectZKM:mainfrom
eeemmmmmm wants to merge 1 commit intoProjectZKM:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The assert_bool checks for is_srl, is_sra, is_ror, and is_real were called twice - once in the flags array loop (line 476-479) and again individually below. This added 4 redundant constraints to the proof system. Removed the duplicates to reduce prover overhead.