Change webpack config to support use of SystemJS #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set name to publish to the `@ptv.js` npm organization Update urls
|
Hey @pixelami, I totally missed this PR. I notice we currently use this in SDK. Is it doing anything right now without this PR merged or is it simply a clone currently? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the webpack.config.js change required to allow react-scripts to build code that explicitly uses
systemjsThe path is applied to a branch created from
react-scripts-3.4.1.This fork of
react-scriptsis published as@ptv.js/react-scripts-3.4.1.Hopefully by mirroring the upstream version it will be easier to track and pull upstream changes.