Open
Conversation
divide by the quantity `(scaling[0] * scaling[1])` (instead of just scaling[0] and then multiplying by scaling[1]). I don't think this changes the relative order of list_inliers though because the three places where list_of_normalization_value is computed all do the same thing and list_of_normalization_value is just a normalization constant when computing list_inliers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
should this divide by the quantity
(scaling[0] * scaling[1])(instead of justscaling[0]and then multiplying byscaling[1])? I don't think this changes the relative order of list_inliers though because the three places where list_of_normalization_value is computed all do the same thing and list_of_normalization_value is just a normalization constant when computing list_inliers