Skip to content

fix wrongfully kicking players when releasing a critter #3290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sors89 wants to merge 1 commit into
base: general-devel
Choose a base branch
from
Open

fix wrongfully kicking players when releasing a critter #3290

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions TShockAPI/Bouncer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2361,12 +2361,8 @@ void rejectForCritterNotReleasedFromItem()

// if released npc not from its item (from crafted packet)
// e.g. using bunny item to release golden bunny
if (args.Player.TPlayer.lastVisualizedSelectedItem.makeNPC != type || args.Player.TPlayer.lastVisualizedSelectedItem.placeStyle != style)
if (args.Player.SelectedItem.makeNPC != type || args.Player.SelectedItem.placeStyle != style)
{
// If the critter is an Explosive Bunny, check if we've recently created an Explosive Bunny projectile.
// If we have, check if the critter we are trying to create is within range of the projectile
// If we have at least one of those, then this wasn't a crafted packet, but simply a delayed critter release from an
// Explosive Bunny projectile.
if (type == NPCID.ExplosiveBunny)
{
if (args.Player.TPlayer.ownedProjectileCounts[ProjectileID.ExplosiveBunny] == 0)
Expand Down