Skip to content

implementation of the gips mult - #98

Merged
PrzeChoj merged 38 commits into
mainfrom
gips_mult
Jul 25, 2026
Merged

implementation of the gips mult#98
PrzeChoj merged 38 commits into
mainfrom
gips_mult

Conversation

@PrzeChoj

@PrzeChoj PrzeChoj commented Jun 21, 2026

Copy link
Copy Markdown
Owner

TODO:

  • initial implementation of gips mult
  • documentation
  • delta is also an parameter that can vary
  • implementation of plot.gips()
  • gips() cannot receive number_of_observations as a list.
  • A little improvement to the documentation, e.g. in gips() the S parameter can be a list. Mention the was_mean_esimated has to be the same for all samples.
  • a better validation for compare_posteriories_of_perms() when the perm1, perm2 are not gips.
  • Validation of number_of_observations -- >= 1, or >= 2.
  • Example of multi-sample in gips vignette

@PrzeChoj
PrzeChoj marked this pull request as draft June 21, 2026 21:31
@PrzeChoj
PrzeChoj marked this pull request as ready for review June 24, 2026 18:25
@PrzeChoj

Copy link
Copy Markdown
Owner Author

Let's wait for the gipsDA package to implement and use this branch befor merging to main. Maybe we will find some bugs.

@PrzeChoj
PrzeChoj marked this pull request as draft July 1, 2026 15:06
PrzeChoj added 3 commits July 8, 2026 11:14
# Conflicts:
#	R/gips_plot.R
Merge branch 'main' into gips_mult

# Conflicts:
#	R/find_MAP.R
#	R/project_matrix.R
@PrzeChoj

Copy link
Copy Markdown
Owner Author

Authors of gipsDA package assured me this is ok

@PrzeChoj
PrzeChoj marked this pull request as ready for review July 25, 2026 14:53
@PrzeChoj
PrzeChoj marked this pull request as draft July 25, 2026 17:33
@PrzeChoj
PrzeChoj marked this pull request as ready for review July 25, 2026 19:19
@PrzeChoj
PrzeChoj merged commit 6012892 into main Jul 25, 2026
11 of 12 checks passed
@PrzeChoj
PrzeChoj deleted the gips_mult branch July 25, 2026 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant