allow decimal comma for numeric with tolerance#18
Open
zeileis wants to merge 1 commit intoPsyTeachR:mainfrom
Open
allow decimal comma for numeric with tolerance#18zeileis wants to merge 1 commit intoPsyTeachR:mainfrom
zeileis wants to merge 1 commit intoPsyTeachR:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm using
webexercisesfor my interactive math exercises. As the exercises is in German many students use a decimal comma rather than a decimal point. So to allow for this as being correct I have adapted thewebex.jscode to replace,with.prior to checking the tolerance:As this is only done if there is a tolerance, I felt that the replacement could be done without further conditions (e.g., adding a class). This is also the behavior of most learning management systems like Moodle etc.
If there is no tolerance, then the answer is likely an integer anyway, so I have not tried to address that case. Not sure whether that might be relevant for some use cases.