Conversation
Introduce RunDownClient for obtaining signed URLs from the run-down service, and gcs_signed module for uploading/downloading checkpoints via those URLs instead of direct GCS SDK access.
Replace direct GCS SDK usage with RunDownClient signed URLs for checkpoint operations. GCS uploader now holds RunDownClient instead of GcsUploadInfo. Falls back to direct GCS when RunDownClient is not configured.
Construct RunDownClient with wallet keypair signing and inject into checkpoint config. GCS credential validation now checks for RunDownClient presence instead of local GCS credentials.
GCS checkpointing now uses run-down signed URLs so local credentials file is no longer needed. Remove credential file detection, docker mount, and env var injection.
Contributor
|
LGTM I've compared it with my solution and it's pretty much the same. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.