Conversation
|
Question for team on this - there are separate check boxes in the PR template for lint and format. What exactly would the lint be for? I ran |
hey @jsonsivar |
|
Just to note, with dfx 0.9.2 all calls default to principal id, not wallet id, but you can make a call with a wallet using the --wallet flag |
Thanks @scott-dn |
|
The PR is set to merge into "backup/master", that's a typo, right? @jsonsivar |
So I'm actually making this PR to the currently deployed version which is in |
Nima-Ra
left a comment
There was a problem hiding this comment.
Looks good to me! Left a suggestion but it's not a needed change. 🙂
| type AddFleekUserResult = | ||
| variant { | ||
| Err: ApiError; | ||
| Ok: opt bool; |
There was a problem hiding this comment.
| Ok: opt bool; | |
| Ok: opt text; |
I think this might be better since a boolean can cause some confusion and afaik all psychedelic canisters use Ok(()) to pass the result.
| } | ||
|
|
||
| add_fleek_user(account); | ||
| Ok(None) |
Why?
We need flexibility to add fleek users because we need to transfer team crowns but it is using the principal id as the owner instead of the cycle wallet id.
How?
Tickets?
None
Contribution checklist?
Security checklist?
Demo?
Optionally, provide any screenshot, gif or small video.