perf(contract): optimize privacy flag storage with SHA256 hashing#172
Open
EmmyKay0026 wants to merge 13 commits intoPulsefy:mainfrom
Open
perf(contract): optimize privacy flag storage with SHA256 hashing#172EmmyKay0026 wants to merge 13 commits intoPulsefy:mainfrom
EmmyKay0026 wants to merge 13 commits intoPulsefy:mainfrom
Conversation
|
@EmmyKay0026 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Resolve conflicts |
Contributor
|
Fix failing contract workflow |
Contributor
|
Please remove the following non-essential changes before merging:
|
Author
|
Alright on it@Cedarich |
Contributor
|
Fix conflict |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #163
Hi @Cedarich, this PR is for issue #163 and optimizes the privacy flag storage in the Soroban contract by switching from a handle-based tuple key to a deterministic hashing algorithm (SHA256). This change aligns the privacy module with the contract's overall cryptographic commitment patterns while moving towards more compact storage keys.
`
The increase in CPU instructions is a calculated trade-off to achieve smaller, deterministic storage keys which reduce long-term ledger fees.